next-error-highlight: 1) incorrect doc string, 2) bad defcustom

[Drew Adams]

1. The doc string should not refer to `t' as "using a persistent
overlay". First, it should speak only of highlighting, not of overlays
(an overlay might be persistent without being visible); users think in
terms of appearance, not implementation. Second, `t' does not make the
highlighting persistent; it is simply not removed by timer - it is
still removed when you move to a different error. The doc string
should say that `t' means that the highlighting of an error is removed
only when you move to another error (with `next-error' or
equivalent). This does mean that there is always one error that is
highlighted, but the current doc string suggests that highlighting of
each error is persistant.

2. If I customize to value `t' and then try to save the customization,
I get this error message:

custom-variable-save: Saving next-error-highlight: This field should
contain a number (floating point or integer)

Not only that, but the previous numeric value is then reinstated,
regardless of whether I set the value to `t' for the current
session. That is, the attempted and unsuccessful save actually ends up
changing the current setting! Very bad.


In GNU Emacs 22.0.50.1 (i386-msvc-nt5.1.2600)
 of 2006-07-19 on BOS-CTHEWLAP2
X server distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-msvc (12.00)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Dired by name

Minor modes in effect:
  encoded-kbd-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<menu-bar> <help-menu> <report-emacs-bug>

Recent messages:
(C:\Emacs-22-2006-07-19-Fran\bin\emacs.exe -q --no-site-file --debug-init
C:\drews-lisp-20)
Loading encoded-kb...done
For information about the GNU Project and its goals, type C-h C-p.
Loading dired...
Loading regexp-opt...done
Loading dired...done
Loading emacsbug...done