emacs-lisp/cl.el (pushnew): void-variable x

[Reiner Steib]

M-x report-emacs-bug writes:

> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:

Create a file "/tmp/pushnew-debug.el" with this lines:

--8<---------------cut here---------------start------------->8---
(setq debug-on-error t)
(require 'cl)
(defvar rs-tmp nil)
(pushnew 'foo rs-tmp)
--8<---------------cut here---------------end--------------->8---

With "emacs -Q /tmp/pushnew-debug.el", I get the following backtrace:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (void-variable x)
  (add-to-list (quote pushnew-internal) x nil (quote eql))
  (let ((pushnew-internal rs-tmp)) (add-to-list (quote pushnew-internal) x nil 
(quote eql)) (setq rs-tmp pushnew-internal))
  (pushnew (quote foo) rs-tmp)
  eval-buffer(#<buffer  *load*> nil "/tmp/pushnew-debug.el" nil t)  ; Reading 
at buffer position 80
  load-with-code-conversion("/tmp/pushnew-debug.el" "/tmp/pushnew-debug.el" nil 
t)
  load("/tmp/pushnew-debug.el" nil t)
  command-line-1(("-l" "pushnew-debug.el"))
  command-line()
  normal-top-level()
--8<---------------cut here---------------end--------------->8---

> In GNU Emacs 22.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.4.9)
>  of 2006-09-11 on bridgekeeper
> X server distributor `The X.Org Foundation', version 11.0.60801000
> configured using `configure '--prefix=/import/xtra/emacs/HEAD' '--with-gtk' 
> '--exec-prefix=/import/xtra/emacs/HEAD-x86_64' 
> 'CFLAGS=-DSITELOAD_PURESIZE_EXTRA=200000 -g''

I have removed all *.elc files and did "make bootstrap".

Reverting Richard's last change to cl.el[1] fixed the problem.  The
following change seems to fix it.  Is this change correct?

--8<---------------cut here---------------start------------->8---
--- cl.el       11 Sep 2006 11:50:52 +0200      1.49
+++ cl.el       11 Sep 2006 12:32:09 +0200      
@@ -160,7 +160,7 @@
   (if (symbolp place)
       (if (null keys)
          `(let ((pushnew-internal ,place))
-            (add-to-list 'pushnew-internal x nil 'eql)
+            (add-to-list 'pushnew-internal ,x nil 'eql)
             (setq ,place pushnew-internal))
        (list 'setq place (list* 'adjoin x place keys)))
     (list* 'callf2 'adjoin x place keys)))
--8<---------------cut here---------------end--------------->8---

> Important settings:
>   value of $LC_ALL: nil
>   value of $LC_COLLATE: POSIX
>   value of $LC_CTYPE: address@hidden
>   value of $LC_MESSAGES: nil
>   value of $LC_MONETARY: nil
>   value of $LC_NUMERIC: nil
>   value of $LC_TIME: nil
>   value of $LANG: en_US
>   locale-coding-system: iso-8859-15
>   default-enable-multibyte-characters: t

> Major mode: Emacs-Lisp

> Minor modes in effect:
>   tooltip-mode: t
>   tool-bar-mode: t
>   mouse-wheel-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   unify-8859-on-encoding-mode: t
>   utf-translate-cjk-mode: t
>   auto-compression-mode: t
>   line-number-mode: t

> Recent input:
> <help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
> <help-echo> <help-echo> <help-echo> <down-mouse-1> 
> <mouse-1> M-x r e p o <tab> r <tab> <return>

> Recent messages:
> (emacs -q -no-site-file pushnew-debug.el -l pushnew-debug.el)
> For information about the GNU Project and its goals, type C-h C-p.
> Loading debug...done
> Entering debugger...
> Loading help-mode...done
> Making completion list...
> Loading emacsbug...
> Loading regexp-opt...done
> Loading emacsbug...done

Bye, Reiner.

[1]
2006-09-10  Richard Stallman  <address@hidden>

        [...]
        * emacs-lisp/cl.el (pushnew): Use add-to-list when convenient.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/