[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-lisp/cl.el (pushnew): void-variable x
From: |
Richard Stallman |
Subject: |
Re: emacs-lisp/cl.el (pushnew): void-variable x |
Date: |
Tue, 12 Sep 2006 17:44:23 -0400 |
Honestly, I think using `add-to-list' here makes no sense.
Since we have the variable as a symbol and we're macro-expanding, we can
just use `(unless (member ,element ,var) (setq ,var (cons ,element ,var)))
That'll be a lot more efficient than going through a function call to
add-to-list, using an aux-var accessed via symbol-value and set and checking
`append' arg etc...
Maybe you're right, but note that it can't actually be `member' in
this case, not by default, since the default comparison function for
pushnew is `eql'.
- Re: emacs-lisp/cl.el (pushnew): void-variable x, (continued)
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Miles Bader, 2006/09/14
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/20
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Miles Bader, 2006/09/20
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/21
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Miles Bader, 2006/09/21
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/21
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Richard Stallman, 2006/09/21
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/22
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Miles Bader, 2006/09/22
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/22
- Re: emacs-lisp/cl.el (pushnew): void-variable x,
Richard Stallman <=
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Stefan Monnier, 2006/09/12
- Re: emacs-lisp/cl.el (pushnew): void-variable x, Kim F. Storm, 2006/09/13