emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Useless Local Variable in etc/grep.txt


From: Reiner Steib
Subject: Re: Useless Local Variable in etc/grep.txt
Date: Sat, 07 Oct 2006 12:46:11 +0200
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux)

On Sat, Oct 07 2006, Sven Joachim wrote:

> When visiting etc/grep.txt, I was asked about the variable
> buffer-read-only.

Independent of etc/grep.txt, I'd suggest to add `buffer-read-only' to
the list of safe local variables:

--8<---------------cut here---------------start------------->8---
--- files.el    02 Oct 2006 10:24:22 +0200      1.859
+++ files.el    07 Oct 2006 12:43:53 +0200      
@@ -2397,10 +2397,10 @@
 ;;
 ;; For variables defined in the C source code the declaration should go here:
 
-;; FIXME: Some variables should be moved according to the rules above.
 (mapc (lambda (pair)
        (put (car pair) 'safe-local-variable (cdr pair)))
-      '((fill-column                     . integerp) ;; C source code
+      '((buffer-read-only                . booleanp) ;; C source code
+       (fill-column                     . integerp) ;; C source code
        (indent-tabs-mode                . booleanp) ;; C source code
        (left-margin                     . integerp) ;; C source code
        (no-update-autoloads             . booleanp)
--8<---------------cut here---------------end--------------->8---

> Although I answered 'n', the buffer was made read-only anyway, so
> the local variable seems superfluous.

grep-mode makes the buffer read-only, so we can remove it, AFAICS.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]