Re: Invalid Images crash Emacs

[Chong Yidong]

Leo <address@hidden> writes:

> I was trying to Change some icons in the images dir and found a way to
> crash emacs. It is 100% reproducible. Tested in GNU Emacs 23.0.0.6
> (i686-pc-linux-gnu, GTK+ Version 2.8.20) of 2006-11-01.
>
> Steps to reproduce:
>     1.Backup:
>       etc/images/gnus/toggle-subscription.xpm
>       etc/images/mail/save.xpm
>       etc/images/mail/save-draft.xpm
>     2.Create empty files:
>       etc/images/gnus/toggle-subscription.xpm
>       etc/images/mail/save.xpm
>       etc/images/mail/save-draft.xpm
>     3. M-x gnus
>     4. C-x 5 b *Group* RET
>     5. Crash

The following patch stops the bug.  Jan, can you confirm if it's the
correct fix?

*** emacs/src/gtkutil.c.~1.97.~ 2006-10-17 13:29:55.000000000 -0400
--- emacs/src/gtkutil.c 2006-11-02 12:58:48.000000000 -0500
***************
*** 3720,3726 ****
  
        if (img->load_failed_p || img->pixmap == None)
          {
!           if (wicon) gtk_widget_hide (wicon);
            continue;
          }
  
--- 3720,3731 ----
  
        if (img->load_failed_p || img->pixmap == None)
          {
!           if (wicon)
!           gtk_widget_hide (wicon);
!         else
!           gtk_toolbar_insert (GTK_TOOLBAR (x->toolbar_widget),
!                               gtk_tool_button_new (NULL, ""),
!                               i);
            continue;
          }