[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacsclient horribly broken
From: |
Stefan Monnier |
Subject: |
Re: emacsclient horribly broken |
Date: |
Thu, 02 Nov 2006 18:38:28 -0500 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.90 (gnu/linux) |
>> --- server.el 02 Nov 2006 14:00:25 -0500 1.117
>> +++ server.el 02 Nov 2006 14:03:12 -0500
>> @@ -112,6 +112,7 @@
>> :version "22.1")
>> (put 'server-auth-dir 'risky-local-variable t)
>>
>> +;; FIXME: This should not be a global var, but stored in the process's
>> plist.
>> (defvar server-auth-key nil
>> "The current server authentication key.")
>> (put 'server-auth-key 'risky-local-variable t)
>> @@ -311,7 +312,7 @@
>> (ignore-errors
>> ;; Delete the socket or authentication files made by previous
>> ;; server invocations.
>> - (if (eq (process-contact server-process :family) 'local)
>> + (if (not server-use-tcp)
>> (delete-file (expand-file-name server-name server-socket-dir))
>> (setq server-auth-key nil)
>> (delete-file (expand-file-name server-name server-auth-dir)))))
>>
> Stefan, do you want to commit this, or do I fix it to put the server
> type in the process plist (which is also trivial)?
You misunderstand the purpose of this code: it is not to clear the data of
`server-process' (this would/should be done in the process's sentinel
instead). It is to clear the path for the new process. The file we want to
remove may be leftover from some other Emacs session (mabye even still
running).
I'll commit a patch,
Stefan
- Re: emacsclient horribly broken, (continued)
- Re: emacsclient horribly broken, Juanma Barranquero, 2006/11/01
- Re: emacsclient horribly broken, Tim Van Holder, 2006/11/02
- Re: emacsclient horribly broken, Juanma Barranquero, 2006/11/02
- Re: emacsclient horribly broken, Tim Van Holder, 2006/11/02
- Re: emacsclient horribly broken, Juanma Barranquero, 2006/11/02
- Re: emacsclient horribly broken, Tim Van Holder, 2006/11/02
- Re: emacsclient horribly broken, Stefan Monnier, 2006/11/02
- Re: emacsclient horribly broken, Juanma Barranquero, 2006/11/02
- Re: emacsclient horribly broken,
Stefan Monnier <=
- Re: emacsclient horribly broken, Juanma Barranquero, 2006/11/02
- Re: emacsclient horribly broken, Juanma Barranquero, 2006/11/02
- Re: emacsclient horribly broken, Richard Stallman, 2006/11/03
- Re: emacsclient horribly broken, Juanma Barranquero, 2006/11/03