Re: pretest crashes on vm-visit-folder

[Robert Marshall]

On Sun, 03 Dec 2006, Jan Djärv wrote:

> Robert Marshall skrev:
>> On Sat, 02 Dec 2006, Chong Yidong wrote:
>> 
>>> robert marshall <address@hidden> writes:
>>>
>>>> I'm using the mail reader vm (version 7.19), start up emacs -Q, add
>>>> the vm directory to the load path M-x vm-visit-folder and selected a
>>>> mail folder and then used v (bound to vm-visit-folder) to visit
>>>> another folder and I get the following crash (22.0.90 didn't have this
>>>> problem)
>>>>
>>>> Program received signal SIGSEGV, Segmentation fault.
>>>> 0x080eed0a in update_frame_tool_bar (f=0x88697b0) at gtkutil.c:3799
>>>> 3799                 GtkImage *wimage = GTK_IMAGE (chlist->data);
>>> This is almost certainly due to my following change:
>>>
>>> 2006-11-04  Chong Yidong  <address@hidden>
>>>
>>>     * gtkutil.c (update_frame_tool_bar): If icon image is invalid and
>>>     wicon is null, insert an empty button.
>>>
>>> Could you verify that backing out this patch solves the problem?
>> 
>> 
>> I confirm that the crash no longer occurs when that patch is backed out
>> 
>> 
>> Thank you!
>> 
>>> The patch was originally introduced to fix the problem described in
>>> the thread "Invalid Images crash Emacs", at
>>>
>>> http://lists.gnu.org/archive/html/emacs-pretest-bug/2006-11/msg00019.html
>>>
>>> Jan, do you have any idea what we're missing here?
> 
> Yes.  When modifying a tool bar item, we assumed it had an image.  But
> that is not true, in the case where an emåty button has been inserted.
> 
> I've checked in a fix, plrease try it.
> 

new version of gtkutil.c retrieved and it works for me - there is no longer
a crash


Robert
-- 
Robert Marshall