|
From: | Lennart Borgman |
Subject: | Re: Shell completion on w32 uses "/" instead of "\" |
Date: | Thu, 21 Dec 2006 00:44:24 +0100 |
User-agent: | Thunderbird 1.5.0.9 (Windows/20061207) |
Lennart Borgman wrote:
Why not set (buffer-locally) a different variable (such as"shell-uses-backslashes") when starting the inferior process? That seemsmore inline with what we usually do, rather than make a global variable buffer-local because we later (re)compute something that depends on the value the global variable had when the buffer was created.Because we must check that value with for example w32-shell-dos-semantics.
Eh, that was a bad argument from me. (My brain just told me that it would not exist in w32-shell-dos-semantics, but that is wrong. In elisp.)
Yes, we could do it the way you propose and check for the existence of this variable in w32-shell-dos-semantics. If it does not exist then we have an error (because there can only be a shell in a buffer and then this variable should be set). I think that is a clear advantage.
But maybe it is better to still use the value of shell-file-name so the semantics for the backslash choice still is in w32-shell-dos-semantics? I think so.
[Prev in Thread] | Current Thread | [Next in Thread] |