emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: safe-local-variable stuff


From: Reiner Steib
Subject: Re: safe-local-variable stuff
Date: Wed, 03 Jan 2007 14:31:59 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.92 (gnu/linux)

On Wed, Jan 03 2007, Peter Dyballa wrote:

> When I save a *compilation* buffer and I later visit that file, the
> GNU Emacsen from CVS (22.0.*, 23.0.0) complain about the
> default-directory variable used. Is there some reason why this
> variable is treated as unsafe? Why are the *compilation* buffers
> settings this unsafe variable at all?

I think it makes sense to mark `default-directory' as safe.  If nobody
objects, I'll commit this change:

--8<---------------cut here---------------start------------->8---
--- files.el    03 Jan 2007 12:13:53 +0100      1.875
+++ files.el    03 Jan 2007 14:21:21 +0100      
@@ -2442,6 +2442,7 @@
 (mapc (lambda (pair)
        (put (car pair) 'safe-local-variable (cdr pair)))
       '((buffer-read-only                . booleanp) ;; C source code
+       (default-directory               . string-or-null-p) ;; C source code
        (fill-column                     . integerp) ;; C source code
        (indent-tabs-mode                . booleanp) ;; C source code
        (left-margin                     . integerp) ;; C source code
--8<---------------cut here---------------end--------------->8---

We could also use `file-directory-p' or `stringp' instead of
`string-or-null-p', but I think `string-or-null-p' is the best choice.

> Or did I miss some customisation?
>
> One AUCTeX variable is treated as unsafe, too: TeX-command-default. 

emacs-pretest is the wrong list for this.  I'll answer to this part on
auctex-devel (Cc-ing you).

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]