Re: query-replace-regexp slow for evaluated lisp expressions

[Aaron S. Hawley]

Quoting Chris Moore <address@hidden>:

> "Aaron S. Hawley" <address@hidden> writes:
>
> > Then, do the most basic of replacements that would never be done in
> > practice, but shows how slow interactive regexp replacements can be:
>
> Or just replace it with \,\& for an even simpler test case.

Damn right.

> Does this patch fix the bug?

Yes, it does.  I felt confident your patch would as soon as I looked at it.

When reporting the bug I had narrowed the problem to that section of  
replace.el and to the `noedit' variable, but had no clue what the  
resolution of the bug was going to be take.

Thanks for taking a look into this, Chris.
/a

> --- old/replace.el      2007-01-07 01:40:26.000000000 +0100
> +++ replace.el  2007-01-07 01:40:42.000000000 +0100
> @@ -1518,8 +1518,7 @@
>               (set-match-data real-match-data)
>               (setq next-replacement
>                     (funcall (car replacements) (cdr replacements)
> -                            replace-count)
> -                   noedit nil))
> +                            replace-count)))
>             (if (not query-flag)
>                 (let ((inhibit-read-only
>                        query-replace-skip-read-only))