emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: problem with tumme.el


From: Mathias Dahl
Subject: Re: problem with tumme.el
Date: Fri, 12 Jan 2007 09:49:10 +0100
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (windows-nt)

address@hidden writes:

> The command that generated this: jpegtran -rotate 90 -copy all
> file.jpg > ~/.emacs.d/tumme/.tumme_rotate_temp
>
> The problem is that the ">" fails if the file already exists.
>
> So I made a change to "tumme-rotate-original" that checks if that
> file is there and deletes it before running the current rotate
> command.

Really strange. I rotate images all the time with tumme and I have
never seen this problem. Normally ">" has no problem overwriting old
files.

If you from the shell do

 $ echo blabla > ~/.emacs.d/tumme/.tumme_rotate_temp

does it work?

Did you also try the jpegtran command line "manually", in the shell?

> Here is a patch:
>
> *** tumme.el.~1~  Thu Aug 24 15:12:48 2006
> --- tumme.el      Thu Jan 11 13:57:41 2007
> ***************
> *** 1886,1889 ****
> --- 1886,1891 ----
>         (if (not (string-match "\.[jJ][pP[eE]?[gG]$" file))
>             (error "Only JPEG images can be rotated!"))
> +       (if (file-exists-p tumme-temp-rotate-image-file)
> +       (delete-file tumme-temp-rotate-image-file))
>         (setq command (format-spec
>                        tumme-cmd-rotate-original-options
>

Thanks!

However, I would like to understand why this fails before applying that patch
(which on my system is not needed). Not that the patch is dangerous in
any way, but it is always good to keep the code as small as possible.

Does anyone have an idea?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]