Re: fix for parallel make failure

[Dan Nicolaescu]

Eli Zaretskii <address@hidden> writes:

  > > From: Dan Nicolaescu <address@hidden>
  > > Date: Wed, 24 Jan 2007 10:13:52 -0800
  > > 
  > > I got a report for a parallel make failure when doing:
  > > 
  > > make -j4 -C lisp updates 
  > 
  > Thanks.  People should really try to use -j more, as it reveals subtle
  > problems in our Makefile's.
  > 
  > > Is this patch correct?
  > 
  > Yes, I think so.  But can you explain why Emacs tries to load
  > loaddefs.el?  I'm afraid I don't see the reason, and I cannot judge

I misspoke. Emacs is not trying to load loaddefs.el, it's trying to
read it. Both the finder-data and custom-deps make targets read the
loaddefs.el file (well, they read all the elisp files). 

To read a file emacs does a stat syscall followed by an open call. 
In the parallel make case it is possible that loaddefs.el gets deleted
in between those 2 calls... 



  > the correctness of the patch without understanding the exact problem.
  > The patch you suggested serializes the build more than it is now;
  > understanding the reason for loading loaddefs could suggest an
  > alternative patch that avoids the additional serialization.