emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 22.0.95 fails to link (missing -lX11) on Solaris with Sun cc


From: Jan Djärv
Subject: Re: 22.0.95 fails to link (missing -lX11) on Solaris with Sun cc
Date: Mon, 05 Mar 2007 08:51:14 +0100
User-agent: Thunderbird 1.5.0.9 (X11/20070212)



Jan Djärv skrev:


Chong Yidong skrev:
Problem seems to be that LIB_XFT on Solaris 10 does NOT include -lX11,
despite what it says in src/Makefile.in.

This patch (reverts Jan 26 change) fixes it for me on Solaris 10,
don't know if it breaks anything else. It can't hurt to include -lX11
twice, can it?

*** Makefile.in 17 Feb 2007 02:36:10 -0000 1.338
--- Makefile.in 2 Mar 2007 22:48:07 -0000
***************
*** 403,410 ****
  #endif /* not USE_X_TOOLKIT */
    #if HAVE_XFT
- #undef LIB_X11_LIB /* XFT_LIBS includes -lX11 */
- #define LIB_X11_LIB
  address@hidden@
  #endif /* HAVE_XFT */
  --- 403,408 ----

Jan, this was your patch.  Can you comment on the proposed fix?

What is the point of not having -lX11 in XFT_LIBS? Sounds like a bug in the installed Xft to me. Where did it come from, is it part of Solaris 10 or added on later. I guess two -lX11 couldn't hurt.


I see that pkg-config --libs gtk+-2.0 on GNU/Linux does not include -lX11, yet it gets linked in because of implicit dependencies. It may be that pkg-config relies on this, but the Solaris ld does not handle this the same way as GNU ld. After all, the Solaris ld does seem to know which library is missing.

Anyway, the patch installed is OK, but I wonder if we will see more of these errors if Emacs starts to use pkg-config for more packages?

        Jan D.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]