emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Find this error in... Changes in complete.el?


From: Nick Roberts
Subject: Re: Find this error in... Changes in complete.el?
Date: Wed, 14 Mar 2007 10:41:55 +1300

 > Anyhoo, hit enter in compilation-mode to select the next error works
 > opening the mini-windows with the prompt...
 >   Find this error in (Default BLAH.c): /path/to/cwd
 > 
 > Previously hitting tab-tab would list possible completions, including
 > folders. Now only files are listed.
 > 
 > Previously I could navigate to the correct file by typing part of the
 > directory name, hitting tab to complete the name...
 > 
 > Now it just goes "beep" and does nothing. The directory name is not a
 > valid completion.
 > 
 > I believe, but not sure its the changes that went into "complete.el"
 > in the last few days.
 > 
 > Is there any work-around to recover the previous behaviour?

I think it's due to this change

2006-07-18  Stefan Monnier  <address@hidden>

        * progmodes/compile.el (compilation-find-file): Handle the
        cases where the user selects a non-existent file.


Does the patch below restore the old behaviour for you?


It's not a fix because it undoes whatever Stefan's patch intended, which I
don't quite understand because I have a different problem when a generate this
message (with a linker error):

Find this error in (default In function `myprint':/home/nickrob/myprint.c): ~/

because my compilation message (gcc version 4.1.0) is:

myprint.o: In function `myprint':/home/nickrob/myprint.c:27: undefined
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 reference to `mysquare6'

where everything above ^^^^ is matched by the error regexp.

-- 
Nick                                           http://www.inet.net.nz/~nickrob



*** compile.el  21 Jan 2007 23:13:40 +1300      1.417
--- compile.el  14 Mar 2007 10:29:23 +1300      
*************** Pop up the buffer containing MARKER and 
*** 1862,1878 ****
            (let* ((name (read-file-name
                          (format "Find this %s in (default %s): "
                                  compilation-error filename)
!                         spec-dir filename t nil
!                         ;; Try to make sure the user can only select
!                         ;; a valid answer.  This predicate may be ignored,
!                         ;; tho, so we still have to double-check afterwards.
!                         ;; TODO: We should probably fix read-file-name so
!                         ;; that it never ignores this predicate, even when
!                         ;; using popup dialog boxes.
!                         (lambda (name)
!                           (if (file-directory-p name)
!                               (setq name (expand-file-name filename name)))
!                           (file-exists-p name))))
                   (origname name))
              (cond
               ((not (file-exists-p name))
--- 1862,1868 ----
            (let* ((name (read-file-name
                          (format "Find this %s in (default %s): "
                                  compilation-error filename)
!                         spec-dir filename t nil))
                   (origname name))
              (cond
               ((not (file-exists-p name))




reply via email to

[Prev in Thread] Current Thread [Next in Thread]