diary-date-forms customization too late

[Stephen Berman]

If you call (diary) from your init-file and use the Custom interface
to customize diary-date-forms, the customization gets evaluated after
diary-font-lock-keywords has been set, so your customized date form
does not get fontified as it should.  To reproduce:

1. Let your ~/.emacs consist only of the following, which shows the
result of having set diary-date-forms via the Custom interface:

txtiYZ_lkEwnK.txt
Description: ~/.emacs

2. emacs -Q
3. M-x calendar
4. In the Calendar, type `s' to show the whole diary
5. Switch to the diary buffer and on a new line type this:

Sat, Apr 7, 2007 Today's entry

According to the customization, "Sat, Apr 7, 2007 " should have diary
face, but after doing steps 1-5 only "Sat," has diary face.  Also,
doing `C-h v diary-font-lock-keywords' shows its default value, not
the result of the customization.

If you start over and immediately after step 4 do the following:

4a. M-x unload-feature RET diary-lib RET

and then step 4 again, doing `C-h v diary-font-lock-keywords' now
shows the result of the customization; however, next doing step 5
still does only shows "Sat," with diary face.  Only after killing the
diary buffer and again repeating steps 4 and 5 do you finally get
"Sat, Apr 7, 2007 " with diary-face.

Since this bug seems similar to the others involving "too late"
customization that I have reported recently and Glenn Morris fixed, I
tried similar fixes to diary-date-forms, using the :initial and :set
keywords and calling (unload-feature 'diary-lib) and (load
"diary-lib"), but these attempts had no effect.  I could only get the
customization activated by doing the steps in the preceding paragraph.


In GNU Emacs 22.0.96.7 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
 of 2007-04-03 on escher
Windowing system distributor `The X.Org Foundation', version 11.0.70199902
configured using `configure  '--with-x-toolkit=gtk''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  gnus-topic-mode: t
  gnus-undo-mode: t
  tabbar-mwheel-mode: t
  tabbar-mode: t
  recentf-mode: t
  display-time-mode: t
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: identity

Recent input:
j <return> C-x C-x <down> <down> <down> <down> <down> 
C-c , j <return> C-x C-x <up> <C-right> <C-right> <C-right> 
<C-right> <C-right> <C-right> C-c , j <return> C-c 
, j d i a <tab> - m o <tab> <tab> C-g <help-echo> <help-echo> 
<help-echo> <menu-bar> <index> "Misc" "{define-derived-mode}" 
<help-echo> C-x C-x C-c , j d a i r y <backspace> <backspace> 
<backspace> <backspace> m a k <backspace> <backspace> 
<backspace> <backspace> m a k <tab> d <tab> <return> 
C-x C-x <menu-bar> <index> "Misc" "{define-derived-mode}" 
C-c , j d i a r y - s e <tab> t <tab> <return> <S-left> 
C-x C-x <down-mouse-1> <mouse-movement> <mouse-movement> 
<drag-mouse-1> <down-mouse-3> <mouse-3> <down-mouse-1> 
<mouse-1> <return> ( d i a r y - m o d e C-_ ( e v 
a l SPC d i a r y - f o n t - l o c k l <backspace> 
- M-/ <right> <down> <up> C-d <right> <right> <down> 
<up> <backspace> <down-mouse-1> <mouse-1> C-, <down> 
<down> C-, <down-mouse-1> <mouse-1> ) ) C-x C-s <select-window> 
<down-mouse-1> <mouse-1> <down-mouse-1> <mouse-movement> 
<mouse-movement> <drag-mouse-1> <down-mouse-1> <mouse-1> 
C-, <down> <down> C-, <down> <down> <down> <left> <down> 
C-e <left> <left> : <backspace> ; <down> C-x C-s <up> 
<right> <right> <right> <right> <right> <right> ( d 
e f v a r SPC <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <backspace> <right> ; <down> <up> C-x C-s <help-echo> 
<down-mouse-1> <mouse-movement> <mouse-movement> <drag-mouse-1> 
<down-mouse-3> <mouse-3> C-x C-s <down-mouse-1> <mouse-1> 
C-x C-x C-c , j m a k e <tab> d i <tab> <return> <down-mouse-1> 
<mouse-1> <down-mouse-1> <mouse-1> M-x g u <return> 
<up> <up> <up> <up> <up> <up> <up> <up> <return> <return> 
<end> <down-mouse-1> <mouse-movement> <mouse-movement> 
<drag-mouse-1> Q y M-x r e p o r <tab> <return>

Recent messages:
Wrote /home/steve/.emacs.d/site-lisp/calendar.el
Mark set
Auto-saving...done
Retrieving newsgroup: gmane.emacs.pretest.bugs...
Opening nntp server on news.gmane.org...done
Fetching headers for gmane.emacs.pretest.bugs...done
Generating summary...done
Mark set
Discard changes to this group and exit? (y or n) 
Loading emacsbug...done