[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [emacs-wiki-discuss] Planner Appt frozes Emacs?
From: |
Jim Ottaway |
Subject: |
Re: [emacs-wiki-discuss] Planner Appt frozes Emacs? |
Date: |
Tue, 29 Nov 2005 17:24:07 +0000 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) |
>>>>> Seth Falcon <address@hidden> writes:
> Jim,
> Thanks for posting the patch. After updating muse and planner-muse, I
> found planner-appt broke planner such that I could not mark tasks as
> complete (and other actions). Was getting a wrong type error.
> On 25 Nov 2005, address@hidden wrote:
>> Here is a patch [I can't add it to my archive mirror because there
>> are some other changes to planner that I have made that might get
>> mixed in]:
> Applying your patch seems to have fixed things (although I haven't yet
> tested heavily).
> + seth
Thank you. Actually, the patch isn't quite right:
planner-copy-or-move-region is supposed to count how many tasks are
moved. A more precise patch is below, but it's not critical that it
is applied, since the count doesn't seem to be used anywhere.
I have cc-ed this e-mail to Michael Olson just in case he didn't spot
the patch on the mailing list [it's quite important that it is fixed].
--
Jim Ottaway
--- orig/planner-appt.el
+++ mod/planner-appt.el
@@ -1084,8 +1076,16 @@
(if (planner-appt-task-nagging-p (planner-task-description info))
(progn (planner-edit-task-description (nth 0 appt))
ad-do-it)
- (unless (and info time)
- ad-do-it)))))))
+ (if (and info time)
+ ;; Fri Nov 25 13:59:02 GMT 2005: Fix for new [?]
+ ;; behaviour of planner-copy-or-move-region.
+ (progn
+ (forward-line -1)
+ ;; Return nil, otherwise
+ ;; planner-copy-or-move-region's count will be
+ ;; wrong.
+ (setq ad-return-value nil))
+ ad-do-it)))))))
;; NB: this advice leads to two updates of the task appointment
;; section [when updating it is enabled, of course]: it is hard to see