Re: [emms-help] 4.2 release tasks: emms-print-metadata install

[Alex Kost]

Yoni Rabkin (2016-10-30 09:27 -0400) wrote:

> Alex Kost <address@hidden> writes:
>
>> Yoni Rabkin (2016-10-24 21:42 -0400) wrote:
>>
>>> In 4.2 I want emms-print-metadata to be installed by `make install',
>>> just like the manual says it is.
>>>
>>> As far as I can tell emms-print-metadata isn't being installed into
>>> /usr/bin/ by `make install'. Can people confirm this?
>>
>> I confirm, also 'make' doesn't build emms-print-metadata, because it is
>> not specified in "all" target.
>
> Thank you for this.
>
> I've fixed this and it will be released along with version 4.2 in
> November.

I see that you didn't add 'emms-print-metadata' to 'all' target in
commit cbbe098¹, so "make" still doesn't build it.  Was it intentional?

Also you use:

  install -m 755 $(SRCDIR)/emms-print-metadata $(BINDIR)/emms-print-metadata;

This will fail if BINDIR does not exist (this is the case for such
systems as GuixSD or NixOS).  Could you please also add "-D" flag to
"install" command?

¹ 
http://git.savannah.gnu.org/cgit/emms.git/commit/?id=cbbe0980565bc6e9b83d04e11d11f4c7aed9ff4f

-- 
Alex