Re: [Emms-patches] Several patches made for EMMS Debian package

[Arnaud Fontaine]

Hello,

Lucas Bonnet <address@hidden> writes:

> Arnaud Fontaine <address@hidden> writes:
>
>> Hello,
>>
>> I made  several patches to fix  several bugs reported on  EMMS Debian
>> package[0], namely  #648980, #671562 and #672188.  They are available
>> in my  EMMS Git repository[1]  (the first two were  already submitted
>> several months ago but I have got not reply at that time).
>
> Hello,
>
>   sorry for the long absence... I'd  love to apply your patches, but I
> suck at git, how can I fetch them from your repo and apply them to the
> main repo, without breaking everything?

As I have just rebased them on top  of current HEAD, you just have to do
the following:

git remote add arnau git://rcs-git.duckcorp.org/people/arnau/emms.git
git fetch arnau
git merge arnau/master

Then a "git push" should be enough. Hope that helps.

>> Also, I'm not sure about  the XEmacs patch[2] (reported there[3]), it
>> seems to  byte compile fine  but I  haven't checked if  it's actually
>> working as I'm not using XEmacs nor displaying lyrics with EMMS...
>
> Can't  help you  here,  I'm  not using  XEmacs  either,  but it  looks
> harmless enough  to me.  Would the  original bug  reporter be  able to
> confirm that the patch is doing its job?

The package  including this patch has  been uploaded about 7  months ago
and  nobody  has  complained so  far,  so  I  guess  it should  be  fine
;-). Before  uploading, I  just tried  to install  Emms with  XEmacs and
checked  that there  was no  problem anymore  but I  didn't check  if it
actually works with XEmacs.

Regards,
-- 
Arnaud Fontaine