Re: [Fenfire-dev] Re: [ff-cvs] fenfire/org/fenfire/fenpdf/events mousemenu.py

[Tuomas Lukka]

On Fri, Sep 12, 2003 at 12:47:46PM +0300, Matti Katila wrote:
> On Fri, 12 Sep 2003, Tuomas Lukka wrote:
> > On Thu, Sep 11, 2003 at 10:50:20AM -0400, Matti Katila wrote:
> > > -    def __init__(self, fenPDF, states, eventHandler):
> > > +    def __init__(self, fenPDF, states):
> > >          self.fenPDF = fenPDF
> > >          self.states = states
> > > -        self.eventHandler = eventHandler
> > >          self.style = vob.GraphicsAPI.getInstance().getTextStyle('sans', 
> > > 0, 12)
> > >          self.makeMainList()
> > >          self.hideList()
> > > @@ -52,7 +51,7 @@
> > >          vs.put(self.selectListVob, cs)
> > >  
> > >      def showList(self, x, y, who):
> > > -        self.eventHandler.eventGrabber = self.mouse
> > > +        self.fenPDF.events.eventHandler.eventGrabber = self.mouse
> > >          self.dragged = 0
> > >          self.notExecuted = 1
> > >   p("showList")
> > 
> > You're adding a member from afar? It *would* be nicer to call a method
> > of eventHandler to say "Grab is here". 
> > 
> > A better abstraction.
> 
> 
> No the patch did clean only.. 
> 
> > > -    def __init__(self, fenPDF, states, eventHandler):
> > > +    def __init__(self, fenPDF, states):
> 
> ..part. I'll look at the abstraction part at next week.

Ah, true. Sorry, read the latter -+ -part carelessly.

        Tuomas