[Findutils-patches] Re: [PATCH 1/4] Add a test which checks $CWD for find -execdir {} + and ... {} ;

[James Youngman]

On Mon, Apr 12, 2010 at 4:56 PM, Eric Blake <address@hidden> wrote:
> On 04/10/2010 02:33 PM, James Youngman wrote:
>> * find/testsuite/find.gnu/execdir-multiple.exp: New test; verifies
>> that for -execdir +, all the execs occur with the correct workikng
>
> s/workikng/working/

Done.

> If you haven't pushed already, it might be nice to separate whitespace
> cleanup into its own commit.

Done.

>
>>
>> +proc mkdir { dirname } {
>> +    # Not all versions of Tcl offer 'file mkdir'.
>> +    set failed [ catch "file mkdir $dirname" result ]
>> +    if $failed {
>> +     # Fall back on the external command.
>> +     send_log "file mkdir does not work, falling back on exec mkdir\n"
>> +     exec mkdir "$dirname"
>
> Do you want functionality more like 'mkdir -p', which is tolerant of the
> directory already existing, or do you want the error in that case?

No, I expect the directory not to exist.


>> +# Create 4 empty files in each of 6 directories.
>> +# Also create a shell script in each of those 6 directories.
>> +# Run a find command which runs the shell script for each empty file.
>> +# Check to make sure that each file is mentioned exacly once, and that
>
> s/exacly/exactly/

Thanks..

James.