[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[fluid-dev] [PATCH] reverb level fix
From: |
Rui Nuno Capela |
Subject: |
[fluid-dev] [PATCH] reverb level fix |
Date: |
Wed, 14 Jul 2004 13:07:01 +0100 (WEST) |
User-agent: |
SquirrelMail/1.4.2 |
Hi,
Is there any special reason why the reverb level setting is being
commented in, as is on fluid_rev.c, line 535 ?
void
fluid_revmodel_setlevel(fluid_revmodel_t* rev, fluid_real_t value) {
/* fluid_clip(value, 0.0f, 1.0f); */
/* rev->wet = value * scalewet; */
/* fluid_revmodel_update(rev); */
}
IIUC this makes the reverb level fixed on 1.0, and any attempt to change
it e.g via fluid_synth_set_reverb(), is a no-op.
FWIW I'm sending a simple patch to fix this, but I would like to know if
it's there any issue about it.
BTW, QSynth cvs is already up for the recent bank offset feature on
loading soundfont files, as of latest Ken Ellinwood's patch posted earlier
on the list. However I think that is not yet commited on fluidsynth cvs,
at least for the savanah site. May I ask when and if it will ever be?
Bye now.
--
rncbc aka Rui Nuno Capela
address@hidden
fluidsynth-1.0.4-4.patch
Description: Text document
- [fluid-dev] [PATCH] reverb level fix,
Rui Nuno Capela <=