Re: [pooma-dev] [PATCH] C++ correctness fixes

[Jeffrey Oldham]

On Thu, Jun 27, 2002 at 01:41:54PM +0200, Richard Guenther wrote:
> Hi!
> 
> The attached patch provides some fixes for C++ correctness to either
> avoid warnings or, in case of ContextMapper.h, fix the destructor being
> not virtual.
> 
> All of these were catched by gcc3.1, pooma r2 now compiles without
> warnings [apart from using <*.h> rather than <*> includes].
> 
> Richard.
> 
> Btw. is it considered good practice to post patches to this mailinglist?
> I have (after some cleanup) more stuff pending, like introducing HDF5
> I/O classes and activation of CoordinateSystem support (much like the one
> from pooma-2.3.0). For my own development I set up a bitkeeper repository
> to mirror the CVS one, but its not pullable from outside our institute.

Thanks for the submission.  I read it, approved it, and committed it.

Yes, it is appropriate to send patches to the mailing list.  The patch
process is:

1) Create a patch.

2) Check the patch by compiling the POOMA library and, if appropriate,
POOMA test cases.  For example, if changing a Field feature, run all
the src/Field/tests/ tests.

3) Create a ChangeLog entry associated with the patch.  (See the
attached file.)  Be sure to list how the patch was tested.

4) Send to either the pooma-dev email list or to an individual for
comments and possible approval.

5) Commit the patch.  Be sure to note who approved the patch.

6) Send the committed patch to the pooma-dev email list.

FWIW, I'm used to reading the output of 'cvs diff' using this ~/.cvsrc:

    update -d -P
    diff -c -p -N
    cvs -z6

I'm glad you are using POOMA.

Thanks,
Jeffrey D. Oldham
address@hidden

guenther.2002Jul01.ChangeLog
Description: Text document

guenther.2002Jul01.patch
Description: Text document