RE: [pooma-dev] [Q] Field/Relations/RelationList.h:makeOwnCopy()

[Richard Guenther]

Thinking more about it it seems you need the
RelationList::makeOwnCopy(Target&) Target parameter only for the type of
the current target (which is the only one expected to be passed) and use
the retarget() machinery to clone the list item.

The same goes with FieldEngine::makeOwnCopy() which needs to pass down
the subject (of Field type)...

Um well ;) I'll add some docs to the functions.

Thanks anyway, Richard.

On Wed, 29 Jan 2003, Richard Guenther wrote:

> Hi Scott
>
> Jim just suggested to ping you about this... btw. just grepping for uses
> of makeOwnCopy() in the pooma sources I find exactly one instance of
> FieldEngine::makeOwnCopy() (Field::makeOwnCopy()) and this is invoked
> with a *this as its argument.
>
> Any suggestions?
>
> Thanks, Richard.
>
>
> <quoting Jim>
>
> Hi Richard,
>
> My recollection is that this was necessary and used, and probably subtle. It
> might have been better to factor it into two things, but I really can't
> remember the details. I don't know if Scott Haney still subscribes to this
> list - you might ping him at address@hidden
>
>       Jim
>
> -----Original Message-----
> From: Richard Guenther [mailto:address@hidden
> Sent: Wednesday, January 29, 2003 3:27 AM
> To: address@hidden
> Subject: [pooma-dev] [Q] Field/Relations/RelationList.h:makeOwnCopy()
>
> Hi!
>
> In the RelationList class there is a makeOwnCopy() method which
> seems to do two things rather than one - it makes a private copy
> of the relation list _and_ retargets its items to another target.
> Did this make sense or is this bad design? I.e. are the "old"
> targets after copying invalid? Does it make sense to split the
> method into makeOwnCopy() and retarget()? Is this (global) retarget
> feature used/needed at all? I'm just thinking again about
> Field/FieldEngine/FieldEngine.h::makeOwnCopy()'s semantics...
>
> Any ideas?
>
> Richard.
>
> --
> Richard Guenther <address@hidden>
> WWW: http://www.tat.physik.uni-tuebingen.de/~rguenth/
>
>

--
Richard Guenther <address@hidden>
WWW: http://www.tat.physik.uni-tuebingen.de/~rguenth/