freepooma-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pooma-dev] Re: [PATCH] Speed up guard update.


From: Jeffrey D. Oldham
Subject: Re: [pooma-dev] Re: [PATCH] Speed up guard update.
Date: Fri, 16 Jan 2004 09:11:48 -0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624

Richard Guenther wrote:
On Thu, 15 Jan 2004, Jeffrey D. Oldham wrote:


Richard Guenther wrote:

Hi!

This is a refined (aka shorter) patch which unifies the tracking of
up-to-date faces and the special optimized copy for MPI.

Tested on serial ia32 linux with gcc3.4 with no regression.

Ok?

Yes, assuming the user interface did not change.  It looks like
GCFillInfo's interface changed but existing code will still run because
a parameter with a default argument was added.


It depends on where you draw the line between "user" interface and
internal interface.  I'd consider GCFillInfo's internal interface, only
the fillGuards(), setDirty(), etc. methods from the MultiPatchEngine I'd
consider "user" interface - and these ones will still work with old code.
I also changed the various intersectors to take an additional parameter - old 
code will
break if it used this interface (but I consider this not user interface
either).

Great! I interpret this a "no change to the user interface". Would you please commit the patch?

--
Jeffrey D. Oldham
address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]