freeride-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [FR-devel] supposed bug in databus.rb ( -w || -d issues)


From: Laurent Julliard
Subject: Re: [FR-devel] supposed bug in databus.rb ( -w || -d issues)
Date: Sun, 20 Jul 2003 22:16:01 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030529

gabriele renzi wrote:
[story]
I thougth that 'failing to start plugin' and 'failing
to load plugin' were not really useful
debug statements, so I thought that possibly I could
unlock some other debug info using the -d or
-w switches from the intepreter.

well, you better avoid this :) [/story]

so I started to mess up the FR code to hide some of
the most noising stuff, mostly uninitialized
vars from databus.rb.
In this journey I discovered that there is an
unreachable statement in line 1000 of
freebase/lib/databus.rb

      def remove(key)
        return @map.remove[key]
        @slot.notify(:notify_map_remove)
      end


Nice catch! Plus the 'remove' method doesn't exist for Hashes !! Looks like this method was never used before :-) I'm going to fix it.

Now, the core of this message:
Should we bother to have freebase/FR runnning with
$DEBUG=true and warnings enabled ? IMO there
could be lots of subtle bugs to kill this way.
(well, I'm not sure the word 'subtle' exists, but you
got it , I hope..)

More than this, having FR/FB running withouth
linenoise with $DEBUG and warnings enabled would
allow other developers to use this flags when
developing their own code (i.e. plugins for FR pr
aplications using FB).
ATM if someone is going to use -w somewhere he'd get
tons of other warnings unrelated to his own code..

What do you think about this ?

I think it is an excellent idea and should be part of our TODO list for the next release. A little bit of cleanup and sanity check doesn't hurt!

LJ






reply via email to

[Prev in Thread] Current Thread [Next in Thread]