[freesci-develop] glutton: Uninitialized memory read in gfxr_read_pal()

[Alex Angas]

OK, first Purify error. I'm using SQ1VGA to test (not sure if it's a 
good example).

Allocation location call stack:

   view_reorder   [c:\freesci\glutton\src\scicore\decompress01.c:386]
=>     byte *outbuffer = (byte *) malloc(dsize);
   decompress1    [c:\freesci\glutton\src\scicore\decompress1.c:416]
   scir_load_resource [c:\freesci\glutton\src\scicore\resource.c:249]
   scir_find_resource [c:\freesci\glutton\src\scicore\resource.c:720]
... gfxr_interpreter_get_view 
[c:\freesci\glutton\src\gfx\resource\sci_resmgr.c:168] ...
   gfxr_get_view  [c:\freesci\glutton\src\gfx\resmgr.c:469]
   gfxop_check_cel [c:\freesci\glutton\src\gfx\operations.c:1930]
   set_base       [c:\freesci\glutton\src\engine\kgraphics.c:1131]
   k_base_setter  [c:\freesci\glutton\src\engine\kgraphics.c:1176]

Error location call stack:

   gfxr_read_pal1 [c:\freesci\glutton\src\gfx\resource\sci_pal_1.c:57]
=>      int color = resource[pos]
               | (resource[pos + 1] << 8)
               | (resource[pos + 2] << 16)
               | (resource[pos + 3] << 24);
   gfxr_draw_view1 [c:\freesci\glutton\src\gfx\resource\sci_view_1.c:266]
... gfxr_interpreter_get_view 
[c:\freesci\glutton\src\gfx\resource\sci_resmgr.c:182] ...
   gfxr_get_view  [c:\freesci\glutton\src\gfx\resmgr.c:469]
   gfxop_check_cel [c:\freesci\glutton\src\gfx\operations.c:1930]
   set_base       [c:\freesci\glutton\src\engine\kgraphics.c:1131]
   k_base_setter  [c:\freesci\glutton\src\engine\kgraphics.c:1176]
   kBaseSetter    [c:\freesci\glutton\src\engine\kgraphics.c:1197]
   run_vm         [c:\freesci\glutton\src\engine\vm.c:1103]
   game_run       [c:\freesci\glutton\src\engine\vm.c:2061]
   game_run       [c:\freesci\glutton\src\engine\vm.c:2136]
   main           [c:\freesci\glutton\src\main.c:1390]

The little ... are mine, notice the common function between the two (I 
assume code path). Unfortunately I have zero idea about this part of the 
code so if someone could help it would be greatly appreciated.

Regards, Alex.