freetype-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[freetype2] parthw-cleaned fd2b16f: [tfm] Resolve memory leak errors.


From: Parth Wazurkar
Subject: [freetype2] parthw-cleaned fd2b16f: [tfm] Resolve memory leak errors.
Date: Fri, 10 Aug 2018 08:45:37 -0400 (EDT)

branch: parthw-cleaned
commit fd2b16f01fa0444eea1e4a13cceae319b6a8d7a3
Author: Parth Wazurkar <address@hidden>
Commit: Parth Wazurkar <address@hidden>

    [tfm] Resolve memory leak errors.
    
    * src/tfm/tfmobjs.c(tfm_close): Remove double freeing
    of `stream' object.
    
    * src/gf/gfdrivr.c(TFM_Read_Metrics): Fix oversight
    errors.
---
 src/gf/gfdrivr.c  |  1 -
 src/tfm/tfmobjs.c | 15 ++++++---------
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/gf/gfdrivr.c b/src/gf/gfdrivr.c
index acd7f40..df78f76 100644
--- a/src/gf/gfdrivr.c
+++ b/src/gf/gfdrivr.c
@@ -523,7 +523,6 @@
       */
 
       face->tfm_data       = fi;
-      fi                   = NULL;
     }
 
   Exit:
diff --git a/src/tfm/tfmobjs.c b/src/tfm/tfmobjs.c
index 8cd3b5b..7e4ec55 100644
--- a/src/tfm/tfmobjs.c
+++ b/src/tfm/tfmobjs.c
@@ -131,9 +131,9 @@
   FT_LOCAL( void )
   tfm_close( TFM_Parser  parser )
   {
-    FT_Memory  memory = parser->memory;
+    FT_UNUSED( parser );
 
-    FT_FREE( parser->stream );
+    /* nothing */
   }
 
 
@@ -346,13 +346,10 @@
     fi->slant = (FT_ULong)((double)fi->slant/(double)(1<<20));
 
   Exit:
-    if( !ci || !w || !h || !d )
-    {
-      FT_FREE(ci);
-      FT_FREE(w);
-      FT_FREE(h);
-      FT_FREE(d);
-    }
+    FT_FREE(ci);
+    FT_FREE(w);
+    FT_FREE(h);
+    FT_FREE(d);
     return error;
   }
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]