[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Devel] redundant arguments to Bezier_Up and Bezier_Down in ftraste
From: |
David Turner |
Subject: |
Re: [Devel] redundant arguments to Bezier_Up and Bezier_Down in ftraster.c |
Date: |
Fri, 12 Oct 2001 10:32:56 +0200 |
Hi again,
Graham Asher a écrit :
>
> I am now working with the FreeType monochrome rasterizer code. I'd like to
> point out some small inefficiencies in the code.
>
> 1. The functions Bezier_Up and Bezier_Down take arguments giving *both* the
> degree of the curve (2 or 3) and a splitter function. One is implied by the
> other: degree 2 means use Split_Conic and degree 3 means use Split_Cubic.
>
I don't think that's a performance problem since these functions aren't
called that often during rasterization..
> 2. The simple function Update should be merged into Sort, which is the only
> place it is called.
>
Strange, I believed I had already done it. Could you provide a patch ??
Besides, any "modern" compiler should be able to inline it directly into
Sort, since it's a static function.. I doubt you'll see a real performance
improvement here..
Regards,
- David