freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Devel] Re: [Kannada] Re: Problem with freetype rendering of an


From: Lars Knoll
Subject: [Devel] Re: [Kannada] Re: Problem with freetype rendering of an Indic opentype font
Date: Mon, 8 Sep 2003 16:53:07 +0200
User-agent: KMail/1.5.9

On Monday 08 September 2003 16:22, Owen Taylor wrote:
[...]
> > I've attached a patch that fixes the problem and gives correct shaping of
> > the above glyph combination.
>
> I think you accidentally sent the wrong patch, since 99% of it had
> nothing to do with this, but searching for 'opentype' in the patch,

Ooops... sorry about that. Was our VCS playing tricks on me.

> I find:
>
> ===
> @@ -1169,10 +1169,9 @@
>         * the attachment type specified."
>         */
>        desired_attachment_class = flags & IGNORE_SPECIAL_MARKS;
> -      if ( desired_attachment_class )
> +      if ( desired_attachment_class && (*property &
> IGNORE_SPECIAL_MARKS) )
>        {
> -       if ( basic_glyph_class == TTO_MARK &&
> -            *property != desired_attachment_class )
> +       if ( *property != desired_attachment_class )
>           return TTO_Err_Not_Covered;
>        }
>      } else {
> ===

That's the correct diff.

> Hmm, I *guess* you could interpret the opentype spec that way -
> the text is:
>
>   If not zero, skips over all marks of attachment type
>   different from specified.
>
> Perhaps that means:
>
>   If not zero, skips over all marks that have specified
>   attachment type that is different from the type specified
>   here. (Marks not in the MarkAttachClassDef table are
>   not skipped.)
>
> I think it would be very much worth suggesting that the spec be
> fixed here, since the current text is unclear. Last time I had
> a fix for the spec, I sent it to address@hidden, which
> eventually got to the right place.

Thanks for the hint. I'll send a mail to them asking for a clarification.

Best regards,
Lars



reply via email to

[Prev in Thread] Current Thread [Next in Thread]