Re: [Devel] planning next release

[Werner LEMBERG]

> Please consider this patch for how cff_face_init decides if a font
> is bold.

Basically, you've sent two different patches...

> let me know if you need more info.

[Ideally, I would also like to have a ChangeLog entry...]

This snippet isn't clear to me:
 
-        {
-          char  *weight = cff_index_get_sid_string( &cff->string_index,
-                                                    dict->weight,
-                                                    psnames );
-
-
-          if ( weight )
-            if ( !ft_strcmp( weight, "Bold"  ) ||
-                 !ft_strcmp( weight, "Black" ) )
+        if ( cffface->style_name )
+          if ( 0==strncmp( cffface->style_name, "Bold", 4  ) ||
+               0==strncmp( cffface->style_name, "Black", 5 ) )
               flags |= FT_STYLE_FLAG_BOLD;
-          FT_FREE( weight );
-        }

It's a good idea to use the style name for a check whether
FT_STYLE_FLAG_BOLD should be set.  But why do you drop the test for
`dict->weight' completely?  How about a combination of both checks?


    Werner