Re: [ft-devel] patch requested for freetype2/internal header usage (using font_bbox)

[david turner]

Curious.  I wonder if this explains why Xprint's postscript output files
are so badly up the creek (displaying too large under gv)...
(https://bugs.freedesktop.org/show_bug.cgi?id=5574)


  

It might be related, though it's not certain. I can't tell, really.

So, the correct, non-buggy code would be:

 else
  {
    fprintf(out, "/FontBBox [%ld %ld %ld %ld] def\n",
                 ti->ttface->bbox->xMin,
    

                                                      ^^^^^^
Is this a typo?  Did you mean
                 ti->ttface->bbox->xMin * 65536,
  ??

  

                 ti->ttface->bbox->yMin * 65536,
                 ti->ttface->bbox->xMax * 65536,
                 ti->ttface->bbox->yMax * 65536);
  }

    

No, you don't need to multiply by 65535. the values in ttface->bbox are already in
outline coordinates, you simply output them as integers into the Postscript/Type1 stream.

this is consistent with PSType3_createOutlineGlyphs which also outputs glyph points
in outline coordinates.

Actually, this particular codepath doesn't appear to be used regularly.
The output files seem to be mostly going through ttf2pt1 instead, which
might be why the problem hasn't been clearly reported. I'll have to
check all the various font bbox usages, I guess.

  

Hey, don't diss him! Before he got on to it Xprt didn't run at all!
Actually, he was aware of the problem, with the freetype internals, if
not the size misuse:
https://bugs.freedesktop.org/show_bug.cgi?id=603

  

Oh, I'm not dissing anyone, believe me. I'm just finding some irony between the efforts involved
and the end result. that's all, nothing more.

And believe me, I would have called him a moron if that's what I thought (which I don't)

Cheers,

- David Turner
- The FreeType Project  (www.freetype.org)

Thanks,

Drew

  

***********************************************************************************
Information contained in this email message is confidential and may be privileged, and is intended only for use of the individual or entity named above. If the reader of this message is not the intended recipient, or the employee or agent responsible to deliver it to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please immediately notify the address@hidden and destroy the original message.
***********************************************************************************