Re: [ft-devel] freetype 2.3.6 compile error on Mac 10.4

[mpsuzuki]

Hi,

Now I guess Xcode 2.5 defines MAC_OS_X_VERSION_10_5 but without
almost data types (and macros) introduced since Mac OS X 10.5.
The 10.4u SDK in my G4 PowerBook Mac OS X 10.4 was Xcode 2.4.1.

Accoring to Apple's Xcode site, Xcode 2.5 is described as:

>This release is recommended for developers needing to continue
>to use the Tiger tools while running Leopard

>Xcode 2.5 does not support developing for the Leopard SDK
>or Leopard-specific features.

Today, I'm not connected to broadband and I cannot download
Xcode 2.5 about 1GB. After the comparison of headers in Xcode
2.4.1 and 2.5, I will fix the comment in ftmac.c. It will be
done within several days, but the release of 2.6.7 has no need
to wait it.

Regards,
mpsuzuki

On Wed, 25 Jun 2008 02:14:46 +0900
address@hidden wrote:

>Dear Sir,
>
>Just I've fixed (I think) the issue on CVS, please check.
>
>I've checked my G4 PowerBook with Mac OS X 10.4.11 + 10.4u SDK,
>its header file does not define the macro MAC_OS_X_VERSION_10_5.
>But 10.4u SDK bundled in 10.5 defines it. Slightly I'm confused
>about the conditions to reproduce the issue.
>
>Anyway, I improved the parentheses, and fixed configure to check
>ResourceIndex type definition explicitly.
>
>Regards,
>mpsuzuki
>
>On Tue, 24 Jun 2008 17:03:43 +0900
>address@hidden wrote:
>
>>Dear Sir,
>>
>>Thank you for reporting the issue.
>>Your patch is designed to enable 10.5 stuff when built by 10.4u SDK?
>>Or, designed to disable 10.5 stuff? Anyway, the insertion of parentheses
>>improves the readability. Within 24 hours I fill fix.
>>
>>
>>Regards,
>>mpsuzuki
>>
>>On Mon, 23 Jun 2008 22:24:33 -0700
>>Garrick Meeker <address@hidden> wrote:
>>
>>>I'm not sure about this, but it seems that the #if stuff for 10.5 in  
>>>ftmac.c doesn't work, but it works some some extra parentheses.  I'd  
>>>assume the preprocessor uses the usual precedence rules but I don't  
>>>see that in the spec.  Anyway, this patch seems to improve things with  
>>>the 10.4u SDK.  The ResourceIndex check also seems to fail because  
>>>MAC_OS_X_VERSION_10_5 is defined in the 10.4u SDK, but I'm not sure  
>>>how to work around that.
>>>
>>>--- freetype-2.3.6-orig/src/base/ftmac.c     2008-05-21 23:11:03.000000000  
>>>-0700
>>>+++ freetype-2.3.6/src/base/ftmac.c  2008-06-23 14:59:38.000000000 -0700
>>>@@ -134,7 +134,7 @@
>>>                                FSRef*      ats_font_ref )
>>>    {
>>>  #if defined( MAC_OS_X_VERSION_10_5 ) && \
>>>-    MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5
>>>+    (MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5)
>>>
>>>      OSStatus  err;
>>>
>>>@@ -234,8 +234,8 @@
>>>                                  FSSpec*      pathSpec,
>>>                                  FT_Long*     face_index )
>>>    {
>>>-#if ( __LP64__ ) || ( defined( MAC_OS_X_VERSION_10_5 ) && \
>>>-      MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5 )
>>>+#if ( __LP64__ ) || (( defined( MAC_OS_X_VERSION_10_5 ) && \
>>>+      (MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5 )))
>>>      FT_UNUSED( fontName );
>>>      FT_UNUSED( pathSpec );
>>>      FT_UNUSED( face_index );
>>>@@ -1107,8 +1107,8 @@
>>>                             FT_Long        face_index,
>>>                             FT_Face*       aface )
>>>    {
>>>-#if ( __LP64__ ) || ( defined( MAC_OS_X_VERSION_10_5 ) && \
>>>-      MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5 )
>>>+#if ( __LP64__ ) || ((( defined( MAC_OS_X_VERSION_10_5 ) && \
>>>+      MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5 )))
>>>      FT_UNUSED( library );
>>>      FT_UNUSED( spec );
>>>      FT_UNUSED( face_index );