[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[ft-devel] Re: Some public APIs using FT_Int/FT_UInt should be improved
From: |
mpsuzuki |
Subject: |
[ft-devel] Re: Some public APIs using FT_Int/FT_UInt should be improved in future |
Date: |
Fri, 9 Jan 2009 20:15:53 +0900 |
On Fri, 09 Jan 2009 11:10:02 +0100 (CET)
Werner LEMBERG <address@hidden> wrote:
>> I'm sorry, you told to use FT_Long, but I committed FT_UInt32.
>> As you can see, FT_Get_Advances() passes its 4th argument flags to
>> FT_Load_Glyph() whose 3rd argument is declared as FT_UInt32 in
>> public interface.
>
>Actually, it's FT_Int32 (for reasons I no longer know):
>
> FT_EXPORT( FT_Error )
> FT_Load_Glyph( FT_Face face,
> FT_UInt glyph_index,
> FT_Int32 load_flags );
>
>> To match their types, I declared the flag as FT_UInt32.
>
>Hmm. Signed vs. unsigned...
Oops, thank you for pointing out. I replaced FT_UInt32 by
FT_Int32. The signed 32-bit integer flag for FT_Load_Glyph()
is slightly confusing, but it should be next step to correct
them to FT_ULong after the release of freetype-2.3.8.
Regards,
mpsuzuki