[ft-devel] Re: 16bit and LP64 model patch set

[Werner LEMBERG]

> Here is the first patch set including about 40 fragments.

Some comments.

  . Please don't use tabs in the code.

  . patch-03.diff contains changes to builds/atari/FREETYPE.PRJ --
    this looks like an error.

  . The first part of patch-05.diff should probably be sent to the
    gzip guys also.

  . As you have already mentioned earlier, it's better to not add
    stuff like patch-22.diff to work around the broken PureC cpp.
    Instead of investing too much time in writing a tool which handles
    this it's probably sufficient to mention this particular problem
    in Atari's README.TXT, mentioning the (currently) affected macros.
    I'll translate it to German then :-)

  . In patch-26.diff it's probably best to surround the TRACE code
    with #ifdef FT_DEBUG_LEVEL_TRACE ... #endif.  Ditto in other
    patches like patch-32.diff.

All in all, you've done an excellent job!


    Werner