Re: [ft-devel] cubic clean up

[GRAHAM ASHER]

<<<<<<
There is no gain or loss in speed and the quality is the same
>>>>>>

In that case the patch should not be applied. Any change but the very simplest 
has some risk. Risk should only be undergone if there is demonstrable benefit.

Graham




----- Original Message ----
From: Алексей Подтележников <address@hidden>
To: freetype-devel <address@hidden>
Sent: Tuesday, 9 November, 2010 0:50:48
Subject: [ft-devel] cubic clean up

Hi,

This patch should not be controversial. It simplifies the code.
1) It replaces 2 comparisons in FT_MAX and FT_MIN with a single one.
2) It implements a simpler and better check for closeness of control
points to the chord

There is no gain or loss in speed and the quality is the same
(see images).

More on 2). Currently the control points are required to be between
the parallel lines through the chord ends. The proposed check requires
that they are inside a circle. Given an earlier check for the
perpendicular distance to the chord, these are actually almost
equivalent.  So the whole patch is just a clean up.

Thanks,
Alexei