Re: [ft-devel] FreeType Amalgamation

[mpsuzuki]

On Fri, 20 Jan 2012 06:04:04 +0100 (CET)
Werner LEMBERG <address@hidden> wrote:
>> BTW, during the overhaul of PIC mode building, I found there are
>> several macros that would not work if all sources are concatenated.
>> Werner, should we care the inter-module namespace separation of cpp
>> macros?
>
>This is OK with me.
>
>> At present, we care only the intra-module namespace separation.  The
>> easiest way would be the insertion of "#undef" to unsafe macros...
>
>Can you give an example?  Perhaps we can rename macros if it is not
>too cumbersome.

An example is GET_PIC() macro defined by src/xxx/yyypic.h.

sfntpic.h defines as:
        #define GET_PIC(lib) ((sfntModulePIC*)((lib)->pic_container.sfnt))
ttpic.h defines as:
        #define GET_PIC(lib) ((TTModulePIC*)((lib)->pic_container.truetype))

To fix the compiler warning against the redefinition of
same macro differently (during the compilation of
concatenated source in PIC mode), some works are needed.

When I found them, I could not decide which is appropriate
direction quickly; giving some prefix/suffix to separate
them to different namespaces, or the insertions of "#undef
GET_PIC" macros.  Apparently the warning that I was afraid
of won't occur in the standard building, so I could not
decide it quickly...

Regards,
mpsuzuki