freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] [PATCH] replace a few avoidable modulo operations


From: James Cloos
Subject: Re: [ft-devel] [PATCH] replace a few avoidable modulo operations
Date: Wed, 29 Feb 2012 02:15:39 -0500
User-agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.0.93 (gnu/linux)

>>>>> "AP" == Alexei Podtelezhnikov <address@hidden> writes:

AP> Modulo operators against a power-of-two denominator is easily avoidable.
AP> The patch does that and a bit more in some cases to help the least advanced
AP> of compilers.

AP> Please review and apply.
AP> Alexei

As Alexei writes, the conversions from % to & are beneficial for simpler
compilers; they are also at least as easy to read and comprehend.

The same goes for the other simplifications in the patch.

[Following lkml (and now xorg) style here:]

Reviewed-by: James Cloos <address@hidden>

-JimC
-- 
James Cloos <address@hidden>         OpenPGP: 1024D/ED7DAEA6



reply via email to

[Prev in Thread] Current Thread [Next in Thread]