freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] Patch to fix the ttsubpix implementation


From: Werner LEMBERG
Subject: Re: [ft-devel] Patch to fix the ttsubpix implementation
Date: Wed, 16 Jan 2013 19:46:54 +0100 (CET)

> Was just looking at the source base today and found some rather sad
> things added recently.
> 
> Here's a first patch to properly define all the sub-pixel handling
> tables in ttsubpix.h to the appropriate location (in ttsubpix.c,
> defined as constants).  This saves about 55 KB of private RAM per
> process that loads the library on Linux. That's *pretty* bad.
> Please people, be careful about your code.

Thanks, David!  I must admit that I've missed this.  Mea maxima culpa.

Note that the sub-pixel code is not activated by default.  There are
still serious problems with it (especially on the performance side) so
it is marked as experimental for good reasons.  BTW, Erik is
completely reworking it currently.

> I'll hope to provide more cleanups later.

Please don't do that right now; it's probably wasted time.  As soon as
Erik has committed his new code, I'll drop you a note so that you do a
review.

I've applied your patch.


    Werner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]