freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] Undefined behavior


From: Behdad Esfahbod
Subject: Re: [ft-devel] Undefined behavior
Date: Wed, 13 Aug 2014 11:18:43 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

On 14-08-12 11:28 PM, Alexei Podtelezhnikov wrote:
>>> Ok. I still do not think that we should fix the macro, because there
>>> is no good value to return. Returning zero for zero is bad too. One
>>> should not call MSB or the builtins with zero argument, just like one
>>> should not divide by zero. So I'll try to apply fix the callers.
>>
>> It's sometimes more convenient to have such defined behaviors as returning 0
>> for 0 in MSB as it makes caller code both cleaner and safer, like what was
>> there before.
> 
> I pushed all the necessary changes. I do not see *any* possibility now
> to encounter undefined FT_MSB. Please review.

Looks good.  Thanks.

-- 
behdad
http://behdad.org/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]