[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-dev
From: |
Alexei Podtelezhnikov |
Subject: |
Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5 |
Date: |
Sun, 4 Jun 2017 19:03:10 -0400 |
On Jun 4, 2017, at 16:32, Werner LEMBERG <address@hidden> wrote:
>>> Yes and yes. They are ugly, and I wonder whether I should drop the
>>> `OVERFLOW_' part of its names to get `SUB_LONG', `ADD_INT32', etc.
>>
>> Please drop OVERFLOW.
>
> OK.
>
>> I see them as a red flag to rethink the code.
>
> I disagree, at least partially, since...
>
>> The add and sub overflows should not be happening on 32 bits because
>> we limit ourselves to 1Gb bitmaps aka 32768x32768. Even at 1/256
>> pixel resolution there is plenty of space to avoid overflows.
>
> this means that malformed fonts can
> create arbitrarily large values very easily. Ditto for bytecode.
> Checking every addition, subtraction or multiplication for overflow is
> something I want to avoid,
Of course, I am only suggesting rejecting input with unreasonably large
coordinates or metric values.
- [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Hin-Tak Leung, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Alexei Podtelezhnikov, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5,
Alexei Podtelezhnikov <=
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/04
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Markus Trippelsdorf, 2017/06/05
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/06
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Behdad Esfahbod, 2017/06/07
- Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Werner LEMBERG, 2017/06/07
Re: [ft-devel] those OVERFLOW_* macros and Fontval b69 (Re: Freetype-devel Digest, Vol 149, Issue 5, Alexei Podtelezhnikov, 2017/06/05