freetype-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] problems with your branch


From: Kushal K S V S
Subject: Re: [ft-devel] problems with your branch
Date: Mon, 28 Aug 2017 01:30:01 +0530

Attached are two screenshots (using current git) with my Chrome
browser.  In the 96dpi snapshot, the exclamation mark is *smaller*
than in the 72dpi snapshot, which indicates that the glyph image
scaling is completely out of control...  The results with Firefox
are roughly the same.
I've slightly updated the view. Please check.
I am using 50% width of the table for the image and height is 'auto'.
This will keep the proportions of the images correct with respect to
other images in the table.
I agree, it seems weird. But if we scale the image with respect to the size of
the image, the results are not pleasing.
BTW, if I scroll down, then change a viewing option (e.g., switching
from 16 to 20), I'm taken to the top line so that I have to scroll
down again.  It would be nice if this could be avoided somehow.
(spent a lot of time on this ) :(
It seems I need jQuery only for this function.
For all the other functions (including sprite animation) I don't need jQuery.
Another thing to add is some text to `top.html' which shortly explains
to the user what she or he is seeing.  In particular, it should also
show the paths to the used DLLs.  And please replace `Size' with
`Size (pt)' or `Point Size'.
Done.
Oops.  Attached also.
Some other minor things for `runme.sh'.
. Please make FT_TEST_TEST_DLL overridable also.
. You are now using arrays.  Since this is a bash extension you should
  start the script with the proper shebang:
    #! /bin/bash
  This is the quick solution.  A better one is probably to avoid
  bashisms altogether (the tests should work on as much platforms as
  possible), teaching `make_sprite' to understand render mode strings.
. The shell is line oriented, so please remove all unnecessary
  trailing `;' characters.
Done
 BTW, will you be able to make the sprite feature actually work,
probably with zooming?  Right now I see four glyphs side by side,
which doesn't help much.
Done.
Added three animation sequences.
Please check. (Click on any image in the table)
(Will change labels of buttons there)
Could you tell me again what exactly you mean by zooming.
(We can already see the image pixel by pixel clearly in the right iframe.)
Should I add a pause/play button as well?

On Sat, Aug 26, 2017 at 12:00 PM, Werner LEMBERG <address@hidden> wrote:

>> 10. Looking at the HTML output for sizes 16 and 20 of `test.ttf'
>>     (using 72dpi and rendering mode 2), then switching between
>>     sizes 16 and 20, I see that the scaling of the glyph doesn't
>>     fit – the used glyph scaling values should be integer multiples
>>     and nothing else...
>
> I don't clearly understand. Please elaborate.

Attached are two screenshots (using current git) with my Chrome
browser.  In the 96dpi snapshot, the exclamation mark is *smaller*
than in the 72dpi snapshot, which indicates that the glyph image
scaling is completely out of control...  The results with Firefox
are roughly the same.

BTW, if I scroll down, then change a viewing option (e.g., switching
from 16 to 20), I'm taken to the top line so that I have to scroll
down again.  It would be nice if this could be avoided somehow.

Another thing to add is some text to `top.html' which shortly explains
to the user what she or he is seeing.  In particular, it should also
show the paths to the used DLLs.  And please replace `Size' with
`Size (pt)' or `Point Size'.

> Also the attached Makefile.diff is empty.
> Please send it again.

Oops.  Attached also.

Some other minor things for `runme.sh'.

. Please make FT_TEST_TEST_DLL overridable also.

. You are now using arrays.  Since this is a bash extension you should
  start the script with the proper shebang:

    #! /bin/bash

  This is the quick solution.  A better one is probably to avoid
  bashisms altogether (the tests should work on as much platforms as
  possible), teaching `make_sprite' to understand render mode strings.

. The shell is line oriented, so please remove all unnecessary
  trailing `;' characters.

BTW, will you be able to make the sprite feature actually work,
probably with zooming?  Right now I see four glyphs side by side,
which doesn't help much.


     Werner

diff --git a/tests/make_png/Makefile b/tests/make_png/Makefile
index 5e49d58db..695327c92 100644
--- a/tests/make_png/Makefile
+++ b/tests/make_png/Makefile
@@ -4,9 +4,6 @@ BUILD_DIR := $(TOP_DIR)/builds/unix
 include $(TOP_DIR)/builds/unix/unix-def.mk

 SRC_SPRITE = make_sprite.c bitmap.c murmur3.c
-SRC_LIB = $(libdir)/libfreetype.a
-
-OBJS = $(src:.c=.o)

 CFLAGS = -Wall -g
 CC = gcc
@@ -16,7 +13,7 @@ LIBS = -lpng -lharfbuzz -lbz2 -ldl
 all: tests

 tests: $(SRC_SPRITE)
-       $(CC) $(CFLAGS) $(INCLUDE) -o address@hidden $(SRC_SPRITE) $(SRC_LIB) $(OBJS) $(LIBS)
+       $(CC) $(CFLAGS) $(INCLUDE) -o $@ $^ $(LIBS)

 .PHONY: clean force
 clean:



reply via email to

[Prev in Thread] Current Thread [Next in Thread]