[ft-devel] Build fails with harfbuzz older than 1.3.0

[Alan Coopersmith]

I tried building freetype 2.9 today on a Solaris machine with harfbuzz 1.0.6
installed.  (I know, that's old and should be fixed, but let me finish this
first...)

It detected harfbuzz was present at a version higher than the minimum defined
in builds/unix/configure.ac, which is currently: "harfbuzz >= 0.9.21" but the
build failed to compile src/autofit/autofit.c giving the errors:


In file included from freetype2/src/autofit/autofit.c:35:0:
reetype2/src/autofit/afscript.h:35:11: error: ‘HB_SCRIPT_ADLAM’ undeclared here 
(not in a function)
           HB_SCRIPT_ADLAM,
           ^
freetype2/src/autofit/afshaper.c:90:38: note: in definition of macro ‘SCRIPT’
 #define SCRIPT( s, S, d, h, H, ss )  h,
                                      ^
freetype2/src/autofit/afscript.h:278:11: error: ‘HB_SCRIPT_OSAGE’ undeclared 
here (not in a function)
           HB_SCRIPT_OSAGE,
           ^
freetype2/src/autofit/afshaper.c:90:38: note: in definition of macro ‘SCRIPT’
 #define SCRIPT( s, S, d, h, H, ss )  h,
                                      ^
gmake: *** [freetype2/src/autofit/rules.mk:74: freetype2/objs/autofit.lo] Error 
1

Looking at HarfBuzz, those two scripts were first defined in HarfBuzz 1.3.0:
https://github.com/harfbuzz/harfbuzz/commit/691086f131cb6c9d97e98730c27673484bf93f87

The attached patch to map them to HB_SCRIPT_INVALID if they weren't defined
let the compile finish with the old HarfBuzz, but I don't know how to test
how well the resulting code works.  The alternative would be to just raise
the minimum required harfbuzz version in builds/unix/configure.ac from 0.9.21
to 1.3.0.

-- 
        -Alan Coopersmith-               address@hidden
         Oracle Solaris Engineering - https://blogs.oracle.com/alanc

0001-Fix-builds-with-HarfBuzz-versions-older-than-1.3.0.patch
Description: Text Data