Re: [ft-devel] CMake patches from Microsoft's vcpkg project

[Azamat Hackimov]

Hello.

Few comments about CMake project.

Nikolaus, you replaced PROJECT_VERSION with project(freetype VERSION ...) but this syntax requires cmake >= 3.0, so you need to bump cmake_minimum_required() statement.

Also there in CMakeList.txt typo around in line 430 (excess curly bracket on end):

set(CPACK_PACKAGE_VERSION_PATCH ${VERSION_PATCH}})

About version mismatch in library name. This is platform-specific shared object version number, and it's based on libtool version (currently 22.0.16, version_info macros, not package version which is currently 2.9.x). But exact version naming still unclear to me.

2018-03-14 16:27 GMT+05:00 Nikolaus Waxweiler <address@hidden>:

More CMakeLists.txt tweaks.

- Minor version variable cleanup
- Enable implicit symbol hiding for static and shared builds

_______________________________________________
Freetype-devel mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/freetype-devel

--

From Siberia with Love!