Re: [ft] Re: freetype-2.3.10 regression: font breakage, xine fails

[mpsuzuki]

Dear Werner,

I've received the serious bug report from Gentoo people,
freetype-2.3.10 has a bug that PCF font support is broken. 
The bug was introduced during my work for 16-bit & 64-bit
systems, I've written wrong truncation of the number of
properties in PCF font file.

The code I introduced a bug was:

   436      FT_TRACE4(( "  nprop = %d (truncate %d props)\n",
   437                  (int)nprops, nprops - (int)nprops ));
   438  
   439      nprops = nprops - (int)nprops; /* <=========== */
   440  
   441      /* rough estimate */
   442      if ( nprops > size / PCF_PROPERTY_SIZE )
   443      {
   444        error = PCF_Err_Invalid_Table;
   445        goto Bail;
   446      }
   447  
   448      face->nprops = (int)nprops;

The right side was careless duplication of the trace message
in previous line. By this bug, although ftdump counts the face
correctly, most PCF files could not be displayed, because nprops
is set to zero. It should be:

   439      nprops = (int)nprops; /* <==================== */
    
I've confirmed the bug by ftview, and this fix can restore the
functionality of PCF. Thus I've already fixed in git. Also I've
checked BDF driver that has similar structure, there was no
modification of me like such wrong truncation.

The impact of my breaking in PCF driver is wide, so, I'm
sorry, I want you to consider the next release of fixed version,
2.3.10a or 2.3.11.

Regards,
mpsuzuki

P.S.
I must thank Gentoo people (and Martin, especially) for the
effort to detect the exact changeset causing the bug.


On Sun, 11 Oct 2009 01:58:40 +0900
suzuki toshiya <address@hidden> wrote:
>Dear Peter,
>
>Thank you for report. Just 5 min ago I received the bug
>report from Martin, and now I'm trying to fix. Please
>wait 1 hour.
>
>Regards,
>mpsuzuki
>
>On Sat, 10 Oct 2009 20:42:12 +0400
>Peter Volkov <address@hidden> wrote:
>
>  Hi. After bumping freetype-2.3.10 we've received bug report
>http://bugs.gentoo.org/288256 stating that PCF fonts in console (urxvt
>and kde konsole, gnome-terminal) started to look terrible; kde konsole
>shows console8x16.pcf on font list instead of just "Console" (filename
>instead of font name). Also xine fails to start (if interested in output
>it's documented in bug report). The problem was bissected by Martin von
>Gagern to the following commit:
>
>http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=3bda1f9949d20cc46fc76e3876bcff545cc8d665
>
>and reverting it fixed the problem. Is there better fix then reverting
>commit? Thanks in advance for you time,
>-- 
>Peter.
>
>    
>
>_______________________________________________
>Freetype mailing list
>address@hidden
>http://lists.nongnu.org/mailman/listinfo/freetype
>