Re: [Gap-dev-discuss] GWorkspace umounting CD-Roms on OpenBSD

[Sebastian Reitenbach]

On Friday, July 20, 2012 09:19 CEST, Riccardo Mottola <address@hidden> wrote: 
 
> Hi,
> 
> On 07/20/12 01:38, Sebastian Reitenbach wrote:
> >   
> > On Monday, July 16, 2012 18:56 CEST, "Sebastian Reitenbach" 
> > <address@hidden> wrote:
> >   
> >> Hi,
> >>
> >> at least with OpenBSD and allowing user mounts (sysctl kern.usermount=1), 
> >> then, at least when mounting a CD-Rom, the mount point directory changes 
> >> ownership to root:wheel. For USB sticks, the ownership of the mountpoint 
> >> stays the same. manually on the console, I can umount the CD-Rom device.
> >> But trying to drag 'n drop the cd-rom device into the trash, I get the 
> >> error, that I must be root to do that.
> >>
> >> I changed the GWorkspace code, so that it just tries to umount the 
> >> partition, and then, in case it fails, throws the error message.
> >> Also I made the error message a bit more generic (there is usually no 
> >> "root" user under Windows ;).
> >>
> >> What do you think about that?
> > Riccardo, any objection about the proposed change?
> >
> No, the change looks fine to me. It is strange I didn't notice it 
> myself: I never run as root.

I also do not run as root, but with the usermount enabled, at least for 
CD-Rom's,
when the user mounts the CD drive, the directory changes automatically the 
ownership to root:wheel,
but the user is still able to unmount on the command line. For USB sticks, its 
no problem, they
when mounting those as user, they keep the ownership of the user on the 
mountpoint.


> 
> I see there is no more windows exception, but  that should be fine too, 
> because on windows it was essentially circumventing the check.
> 
> Do you want to commit it yourself or should I ?

I'll do that, no problem. I'll also look into Philippe's point, also removing 
the NSDictionary.

thanks,
Sebastian

> 
> Riccardo
> 
>