Re: [gcmd-dev] GnomeCmdFileSelector breaks user-defined keybindings for keycodes such as GDK_KP_xxx and GDP_Page_xxx

[Piotr Eljasiak]

> While trying to bind CTRL+Page_down for moving to the next tab i noticed the
> key wasn't getting processed, it worked fine with CTRL+Page_up instead.
> So looking at the code, it seems we are using some "sensitive" keys that
> could *potentially* be bound to other user-defined shortcuts: processing key
> there imply the keyboard event to not bubble up anymore.
> The attached patch fix *only* the Page_down problem by removing it from the
> switch: i'm still new to the codebase and i don't want to break any previous
> behavior, but i would check for these keycodes if they are already bound to
> any shortcut and if it's the case, just drop out of the "key_pressed"
> handler.

I've removed the hard-coding of CTRL+PgDown (and KP_PgDown) - see commit
27f3c1b424ad072a4833eb95ab65f59b9517fb28. Both shortcuts default to
'Change directory' user action, but can be freely redefined by user.

Enjoy,
Piotr