ginger-dev-list
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Ginger-dev-list] [PATCH] Fix comment format on i18n.json


From: Aline Manera
Subject: Re: [Ginger-dev-list] [PATCH] Fix comment format on i18n.json
Date: Mon, 14 Sep 2015 14:51:19 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0


A minor comment would be to add spaces around *

#*
 * Copyright...
 * ...
 * ...
 *#

On 14/09/2015 12:57, Ramon Medeiros wrote:
The file was using html comments standard (<!--), which causes trouble
when js is reading a json file. After changing to (#**#) standard, now
js can read i18n.json from ginger and show the translated strings.

Signed-off-by: Ramon Medeiros <address@hidden>
---
  ui/pages/i18n.json.tmpl | 34 +++++++++++++++++-----------------
  1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/ui/pages/i18n.json.tmpl b/ui/pages/i18n.json.tmpl
index 56556c3..abb59ee 100644
--- a/ui/pages/i18n.json.tmpl
+++ b/ui/pages/i18n.json.tmpl
@@ -1,20 +1,20 @@
-<!--
-Copyright IBM Corp, 2015
-
-This library is free software; you can redistribute it and/or
-modify it under the terms of the GNU Lesser General Public
-License as published by the Free Software Foundation; either
-version 2.1 of the License, or (at your option) any later version.
-
-This library is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-Lesser General Public License for more details.
-
-You should have received a copy of the GNU Lesser General Public
-License along with this library; if not, write to the Free Software
-Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
--->
+#*
+*Copyright IBM Corp, 2015
+*
+*This library is free software; you can redistribute it and/or
+*modify it under the terms of the GNU Lesser General Public
+*License as published by the Free Software Foundation; either
+*version 2.1 of the License, or (at your option) any later version.
+*
+*This library is distributed in the hope that it will be useful,
+*but WITHOUT ANY WARRANTY; without even the implied warranty of
+*MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+*Lesser General Public License for more details.
+*
+*You should have received a copy of the GNU Lesser General Public
+*License along with this library; if not, write to the Free Software
+*Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+*#

  #unicode UTF-8
  #import gettext




reply via email to

[Prev in Thread] Current Thread [Next in Thread]