ginger-dev-list
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Ginger-dev-list] [PATCH v2] Fix comment format on i18n.json


From: Aline Manera
Subject: Re: [Ginger-dev-list] [PATCH v2] Fix comment format on i18n.json
Date: Mon, 14 Sep 2015 15:21:46 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0


Reviewed-by: Aline Manera <address@hidden>

On 14/09/2015 15:13, Ramon Medeiros wrote:
Changes:

v2:
Add spaces before the * to make more readable

The file was using html comments standard (<!--), which causes trouble
when js is reading a json file. After changing to (#**#) standard, now
js can read i18n.json from ginger and show the translated strings.

Signed-off-by: Ramon Medeiros <address@hidden>
---
  ui/pages/i18n.json.tmpl | 34 +++++++++++++++++-----------------
  1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/ui/pages/i18n.json.tmpl b/ui/pages/i18n.json.tmpl
index 56556c3..a269fec 100644
--- a/ui/pages/i18n.json.tmpl
+++ b/ui/pages/i18n.json.tmpl
@@ -1,20 +1,20 @@
-<!--
-Copyright IBM Corp, 2015
-
-This library is free software; you can redistribute it and/or
-modify it under the terms of the GNU Lesser General Public
-License as published by the Free Software Foundation; either
-version 2.1 of the License, or (at your option) any later version.
-
-This library is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-Lesser General Public License for more details.
-
-You should have received a copy of the GNU Lesser General Public
-License along with this library; if not, write to the Free Software
-Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
--->
+#*
+ * Copyright IBM Corp, 2015
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  
USA
+ *#

  #unicode UTF-8
  #import gettext




reply via email to

[Prev in Thread] Current Thread [Next in Thread]