gm-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gm-devel] New ProtocolManager code and Contact code, please review


From: Jesse Lovelace
Subject: Re: [Gm-devel] New ProtocolManager code and Contact code, please review
Date: Tue, 02 Jul 2002 08:58:36 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020513

Henrik Abelsson wrote:

bool ProtocolManager::IsGM(const Contact& c)

In this case, there is a similar function is in Contact so it may be ok to drop this.


..
void ProtocolManager::ForceKeyX(const Contact& c)

This one i'm not so sure about. This would require the contact to have some sort of callback to both the SSHManager and the protocols, and that might cause a lot of circular referencing.


..
void ProtocolManager::ChangeCipher(const Contact& c, int cipherType, int keysize =-1) ..

Same concerns as above.

-jesse
one




reply via email to

[Prev in Thread] Current Thread [Next in Thread]