[Gnash-commit] gnash/server Movie.cpp Movie.h MovieClipLoader....

[strk]

CVSROOT:        /sources/gnash
Module name:    gnash
Branch:         
Changes by:     strk <address@hidden>   06/02/03 12:53:38

Modified files:
        server         : Movie.cpp Movie.h MovieClipLoader.cpp 
                         Sprite.cpp 

Log message:
        Cleanups and some more docs

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/gnash/server/Movie.cpp.diff?tr1=1.2&tr2=1.3&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/gnash/gnash/server/Movie.h.diff?tr1=1.4&tr2=1.5&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/gnash/gnash/server/MovieClipLoader.cpp.diff?tr1=1.3&tr2=1.4&r1=text&r2=text
http://cvs.savannah.gnu.org/viewcvs/gnash/gnash/server/Sprite.cpp.diff?tr1=1.8&tr2=1.9&r1=text&r2=text

Patches:
Index: gnash/server/Movie.cpp
diff -u gnash/server/Movie.cpp:1.2 gnash/server/Movie.cpp:1.3
--- gnash/server/Movie.cpp:1.2  Sat Jan 28 01:14:33 2006
+++ gnash/server/Movie.cpp      Fri Feb  3 12:53:38 2006
@@ -542,6 +542,9 @@
            root_movie->set_name("_root");
            m->set_root_movie(root_movie);
 
+               // @@ somewhere in here I *might* add _url variable
+               // (or is it a member?)
+
            m->add_ref();
            return m;
        }
Index: gnash/server/Movie.h
diff -u gnash/server/Movie.h:1.4 gnash/server/Movie.h:1.5
--- gnash/server/Movie.h:1.4    Wed Feb  1 14:25:44 2006
+++ gnash/server/Movie.h        Fri Feb  3 12:53:38 2006
@@ -260,6 +260,7 @@
                sound_sample*   get_sound_sample(int character_id);
                virtual void    add_sound_sample(int character_id, 
sound_sample* sam);
 
+               /// Add an execute_tag to this movie_definition's playlist
                void    add_execute_tag(execute_tag* e)
                {
                    assert(e);
@@ -328,7 +329,11 @@
                /// loaded characters.
                void    input_cached_data(tu_file* in);
 
-               /// Create a playable (root) movie instance from a def.
+               /// Create a playable movie_root instance from a def.
+               //
+               /// The _root reference of the newly created instance
+               /// will be set to a newly created sprite_instace (Help!)
+               ///
                movie_interface* create_instance();
        };
 
Index: gnash/server/MovieClipLoader.cpp
diff -u gnash/server/MovieClipLoader.cpp:1.3 
gnash/server/MovieClipLoader.cpp:1.4
--- gnash/server/MovieClipLoader.cpp:1.3        Sat Jan 28 01:14:33 2006
+++ gnash/server/MovieClipLoader.cpp    Fri Feb  3 12:53:38 2006
@@ -225,17 +225,6 @@
 
        log_msg(" target._url: %s\n", target_url.to_string());
 
-#if 0
-       as_value root_url;
-       if ( ! target->get_member("_url", &root_url) )
-       {
-               log_msg("FIXME: no _url member in target!");
-       }
-
-       log_msg(" root._url: type:%d to_string:%s rtty:%s\n",
-               root_url.m_type, root_url.to_string(), typeid(root_url).name());
-#endif
-
        xmlNanoHTTPInit();      // This doesn't do much for now, but in the
                                 // future it might, so here it is...
 
Index: gnash/server/Sprite.cpp
diff -u gnash/server/Sprite.cpp:1.8 gnash/server/Sprite.cpp:1.9
--- gnash/server/Sprite.cpp:1.8 Wed Feb  1 23:52:44 2006
+++ gnash/server/Sprite.cpp     Fri Feb  3 12:53:38 2006
@@ -475,7 +475,12 @@
                case M_URL:
                    //else if (name == "_url")
                {
-                   // our URL.
+                       // A sprite's url is the url this
+                       // sprite has been "downloaded" from.
+                       // If this is an ActionScript-created sprite
+                       // we might use the actions creating
+                       // it as defining where was it "downloaded" from.
+                       //
                    val->set_string("gnash");
                    return true;
                }